Configuration updates. #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RequestData is now used as a bound instance over `ITransportConfiguration` and `IRequestConfiguration` record versions of `TransportConfiguration` and `RequestConfiguration` now exists You can create a new instance of `TransportConfiguration` based off another (with test that all properties get assigned) Ensure only `RequestData` deals is in charge of dealing with global and local configuration. The meant some updates to our request pipelines. We now use a single `RequestData` instance if no per request overrides are provided
Increased the time tolerance for the 'LastUpdate' field comparison from 100 milliseconds to 2 seconds. This change enhances the reliability of the test by accommodating larger variations in timing.
Mpdreamz
added a commit
that referenced
this pull request
Nov 8, 2024
This PR continues #128 and ensures `RequestPipeline` can be shared over many requests unless a local configuration is provided. Similar to `RequestData` being shared in #128. This includes further refactorings: - `DateTimeProvider` is only provided externally once (on `NodePool`) and that instance is used everywhere. Before it could be set seperately on `NodePool` and `TransportConfiguration`, not by design but by necessity. - `RequestPipeline` is no longer disposable (we didn't actually disposed anything). - A new type exists `Auditor` this is now explicitly passed to the methods that need it on `RequestPipeline`. It implements `IReadOnlyCollection<Audit>` and is exposed as such to users. - This PR also merges `DefaultRequestPipeline` and `RequestPipeline` into one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITransportConfigurationandIRequestConfigurationrecord versions of
TransportConfigurationandRequestConfigurationnow existsYou can create a new instance of
TransportConfigurationbased off another (with test that all properties get assigned)Ensure only
RequestDatadeals is in charge of dealing with global and local configuration. The meant some updates to our request pipelines.We now use a single
RequestDatainstance if no per request overrides are provided